Message158351
| Author |
mark.dickinson |
| Recipients |
eric.smith, ezio.melotti, loewis, mark.dickinson, pitrou, serhiy.storchaka, skrah |
| Date |
2012年04月15日.18:48:12 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1334515693.42.0.543675526996.issue14339@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
A few comments:
(1) The patch appears to assume that a Unicode string created with PyUnicode_New(size, 127) will have 'kind' PyUnicode_1BYTE_KIND. While this might be true in the current implementation, I don't know whether this is guaranteed in general. Martin, any comments on this?
(2) The patch doesn't compile with '--with-pydebug': there's a reference to the (now) undefined variable 'buffer' in one of the asserts.
(3) The overflow check looks as though it needs to be reworked. |
|