Message158113
| Author |
neologix |
| Recipients |
nadeem.vawda, neologix, pitrou, sbt |
| Date |
2012年04月12日.08:01:00 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<CAH_1eM3xh9r-PG=O2z5EqDGNFrd2oQZw3Kd8tSTZrdWsACsndg@mail.gmail.com> |
| In-reply-to |
<1334185656.37.0.476304514318.issue14548@psf.upfronthosting.co.za> |
| Content |
>> That's a problem indeed. Perhaps we need a global "fork lock" shared
>> between subprocess and multiprocessing?
>
> I did an atfork patch which included a (recursive) fork lock. See
>
> http://bugs.python.org/review/6721/show
>
> The patch included changes to multiprocessing and subprocess. (Being able to acquire the lock when doing fd manipulation is quite useful. For instance, the creation of Process.sentinel currently has a race which can mean than another process inherits the write end of the pipe. That would cause Process.join() to wait till both processes terminate.)
Indeed, I had a look and it looked good.
I just had a couple minor comments, I'll try to get back to this later
today, or by the end of the week.
> Actually, for Finalizers I think it would be easier to just record and check the pid.
I'd prefer this too. |
|