Message157697
| Author |
pitrou |
| Recipients |
giampaolo.rodola, kristjan.jonsson, pitrou, santoso.wijaya, sbt |
| Date |
2012年04月06日.21:48:13 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1333748572.3367.3.camel@localhost.localdomain> |
| In-reply-to |
<1333748185.7.0.176951622602.issue14310@psf.upfronthosting.co.za> |
| Content |
> Here is a new patch, with more tests.
> Note that the process worker function can't be a member function
> because of how multiprocessing works on Windows.
Some comments:
- I said classmethod, not member function; this is how
test_multiprocessing works, so it should be possible...
- why did you change the gethostbyname() tests?
- before using AF_INET6, you might have to test that IPv6 is available
on the test machine (I think there are variables / functions for that in
test_socket)
- in compareSockets:
+ if org.proto != 0:
+ self.assertEqual(sock.proto, other.proto)
`sock` doesn't seem to exist at all... |
|