Message157663
| Author |
pitrou |
| Recipients |
giampaolo.rodola, kristjan.jonsson, pitrou, santoso.wijaya, sbt |
| Date |
2012年04月06日.12:08:27 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1333714107.88.0.445541158984.issue14310@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Comments about the patch:
- versionadded should be 3.3, not 3.4
- MultiprocessingFunc would deserve a meaningful, PEP8 name; it should also probably be a classmethod on TestSocketSharing
- please use PEP8 for comments (a space after the "#")
- it would be nice to have a test for the ValueError when passing a bytes object of the wrong size
- also, there should be a test that the "family", "type" and "proto" attributes are correctly set on the fromshare() result (perhaps "timeout" too) |
|