Message157484
| Author |
pitrou |
| Recipients |
Eli.Stevens, asvetlov, belopolsky, mark.dickinson, mark.wiebe, pitrou |
| Date |
2012年04月04日.15:02:42 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1333551762.77.0.113481523338.issue11734@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Given than there is no native "half float" in C (AFAIK), does it make sense to have a native variant of half floats?
Also:
+ {'e', sizeof(short), SHORT_ALIGN, nu_halffloat, np_halffloat},
Shouldn't it be 2 rather than sizeof(short)? And why SHORT_ALIGN?
Other comments:
- in the tests, please remove the commented out print() calls
- in the tests, I don't understand why some examples are commented out; you should explain why (add a comment)
- you can add the "import math" at the top-level, rather than in the test method
- in the doc, you need a "versionchanged" or "versionadded" tag to specify that half-float support was added in 3.3
I'll let others review the numerical code, if necessary. |
|