Message 157218 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	kristjan.jonsson
Recipients	alexis, brian.curtin, eric.araujo, jackjansen, kristjan.jonsson, loewis, mhammond, sable, santoso.wijaya, tarek, tim.golden, vstinner
Date	2012年03月31日.18:30:42
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1333218642.77.0.892904286048.issue13210@psf.upfronthosting.co.za>

Content
Why should python compiled with VS2010 have different error codes than one compiled with the older compilers? We could revisit this in a new python version, but for now, we should maintain compatibility across compilers. the errno codes (EAGAIN etc) are provided only as a compatibility for posix apps that test "errno". On windows, we use the WSA return values from the api functions and WsaGetLastError(). The reason this patch is required is that now, the errno constants get pulled in with the WSA ones, and therefore the conditional compilation in errnomodule.c gets mangled. So, the proposed patch is not a change, it is merely reinforcing the previous practice of prefering the native error codes over the 'errno' emulation. Of course, this should be clarified in a comment, as you point out.

Content

Why should python compiled with VS2010 have different error codes than one compiled with the older compilers? We could revisit this in a new python version, but for now, we should maintain compatibility across compilers.
the errno codes (EAGAIN etc) are provided only as a compatibility for posix apps that test "errno". On windows, we use the WSA return values from the api functions and WsaGetLastError().
The reason this patch is required is that now, the errno constants get pulled in with the WSA ones, and therefore the conditional compilation in errnomodule.c gets mangled. So, the proposed patch is not a change, it is merely reinforcing the previous practice of prefering the native error codes over the 'errno' emulation. Of course, this should be clarified in a comment, as you point out.

History
Date	User	Action	Args
2012年03月31日 18:30:42	kristjan.jonsson	set	recipients: + kristjan.jonsson, loewis, mhammond, jackjansen, vstinner, sable, tim.golden, tarek, eric.araujo, brian.curtin, santoso.wijaya, alexis
2012年03月31日 18:30:42	kristjan.jonsson	set	messageid: <1333218642.77.0.892904286048.issue13210@psf.upfronthosting.co.za>
2012年03月31日 18:30:42	kristjan.jonsson	link	issue13210 messages
2012年03月31日 18:30:42	kristjan.jonsson	create

homepage