Message157214
| Author |
loewis |
| Recipients |
alexis, brian.curtin, eric.araujo, jackjansen, kristjan.jonsson, loewis, mhammond, sable, santoso.wijaya, tarek, tim.golden, vstinner |
| Date |
2012年03月31日.17:38:06 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1333215487.21.0.48019007383.issue13210@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
The errnomodule patch shouldn't be checked in as is. Instead, an elaborate comment needs to be added fully explaining the situation with the errno codes, and giving criteria under which cases it is necessary.
On the face value, it's incorrect: if the compiler defines EINVAL, that should be what is used to define errno.EINVAL. It's not at all clear that WSAEINVAL is a better choice. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2012年03月31日 17:38:07 | loewis | set | recipients:
+ loewis, mhammond, jackjansen, kristjan.jonsson, vstinner, sable, tim.golden, tarek, eric.araujo, brian.curtin, santoso.wijaya, alexis |
| 2012年03月31日 17:38:07 | loewis | set | messageid: <1333215487.21.0.48019007383.issue13210@psf.upfronthosting.co.za> |
| 2012年03月31日 17:38:06 | loewis | link | issue13210 messages |
| 2012年03月31日 17:38:06 | loewis | create |
|