Message156803
| Author |
rhettinger |
| Recipients |
anacrolix, giampaolo.rodola, meador.inge, nedbat, rhettinger |
| Date |
2012年03月26日.08:29:55 |
| SpamBayes Score |
0.00018948887 |
| Marked as misclassified |
No |
| Message-id |
<1332750596.21.0.343671032397.issue14373@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
I've just started looking at this. Nice job and good attention to detail on the error checking. Expect to have a few high-level suggestions and a ton of minor edits.
Here are a couple of quick thoughts:
* The comment style needs to switch to the /* style */
* Use the pure python _cache_info by looking it up on the module object.
* I had expected PyList objects rather than links between C structs (following the pure python lru_cache as closely as possible). |
|