Message155881
| Author |
vinay.sajip |
| Recipients |
giampaolo.rodola, r.david.murray, terry.reedy, vinay.sajip |
| Date |
2012年03月15日.12:14:53 |
| SpamBayes Score |
0.009018336 |
| Marked as misclassified |
No |
| Message-id |
<1331813694.31.0.989706241188.issue11959@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
> I notice that your logging test code doesn't override create_socket. Is that no longer needed?
I removed that code from test_logging, but the code in the BitBucket repo shows how I'd like smtpd to be changed.
I would of course prefer to avoid copying stuff from SMTPChannel, as the docstring for TestSMTPChannel indicates. If you could take a look at the suggested changes in
https://bitbucket.org/vinay.sajip/cpython-smtpd/compare/default..mirror/cpython
and let me have your comments, that'd be great. The code in that repo does redefine create_socket. |
|