Message155259
| Author |
Jim.Jewett |
| Recipients |
Jim.Jewett, Mark.Shannon, benjamin.peterson |
| Date |
2012年03月09日.19:23:13 |
| SpamBayes Score |
0.0004190393 |
| Marked as misclassified |
No |
| Message-id |
<1331320994.12.0.629991211548.issue14239@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
So the risk is that descr may be given garbage memory that just happens to look like an object with 1 reference, so that it really does a decref and tries to re-deallocate whatever was there before.
I would rather see the change at the top of the function; just initialize descr to NULL when it is declared, and let the compiler figure out that it can skip the zeroing on some (most) paths. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2012年03月09日 19:23:14 | Jim.Jewett | set | recipients:
+ Jim.Jewett, benjamin.peterson, Mark.Shannon |
| 2012年03月09日 19:23:14 | Jim.Jewett | set | messageid: <1331320994.12.0.629991211548.issue14239@psf.upfronthosting.co.za> |
| 2012年03月09日 19:23:13 | Jim.Jewett | link | issue14239 messages |
| 2012年03月09日 19:23:13 | Jim.Jewett | create |
|