Message154136
| Author |
nadeem.vawda |
| Recipients |
Adam.Groszer, benjamin.peterson, cjw296, eric.araujo, georg.brandl, jaraco, nadeem.vawda, tarek |
| Date |
2012年02月24日.13:41:44 |
| SpamBayes Score |
4.495636e-09 |
| Marked as misclassified |
No |
| Message-id |
<1330090905.77.0.325727368844.issue6884@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
There were bugs in two of the updated tests:
- test_glob_to_re() was doing two levels of escaping (r'\' -> r'\\\\')
for its expected output when it should only do one (r'\' -> r'\\').
- test_process_template() was not converting some of its expected
results to use the native directory separator.
I've attached a patch that fixes these issues. I also took the liberty of
changing the checks for whether the separator needs to be escaped - it's
better to escape everything except "/", just in case someone decides to
port Python to some platform using a weird directory separator that is
neither "/" nor r"\".
With my updated patch, all tests pass on both Windows and Linux, and I've
also manually verified that the buildout.cfg problem and the
sandbox/dummy.py problem (from issue 9691) are both fixed.
Please review (and commit, if my changes are OK). |
|