Message153348
| Author |
eric.araujo |
| Recipients |
eric.araujo, lars.gustaebel |
| Date |
2012年02月14日.16:10:35 |
| SpamBayes Score |
5.399313e-07 |
| Marked as misclassified |
No |
| Message-id |
<1329235837.42.0.144867770777.issue14012@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
I found a few possible bugs in tarfile:
- "mode in 'raw'" can give false positives for '' or 'ra'. Most of the code also checks for "len(mode) > 1", but I find clearer and safer to just use "mode in ('r', 'a', 'w')".
- To use the shadowed builtin "open", tarfile uses both "import as" and a local alias "bltin_open = open". However, the second idiom would break if tarfile were reloaded.
- Error messages don’t say what the invalid mode was. (Error messages are not part of the language, but nonetheless maybe it’s best not to commit that to stable branches.) |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2012年02月14日 16:10:37 | eric.araujo | set | recipients:
+ eric.araujo, lars.gustaebel |
| 2012年02月14日 16:10:37 | eric.araujo | set | messageid: <1329235837.42.0.144867770777.issue14012@psf.upfronthosting.co.za> |
| 2012年02月14日 16:10:36 | eric.araujo | link | issue14012 messages |
| 2012年02月14日 16:10:36 | eric.araujo | create |
|