Message153221
| Author |
eli.bendersky |
| Recipients |
Arfrever, effbot, eli.bendersky, eric.araujo, ezio.melotti, flox, python-dev, scoder, tshepang |
| Date |
2012年02月12日.19:06:22 |
| SpamBayes Score |
1.3703657e-07 |
| Marked as misclassified |
No |
| Message-id |
<1329073583.14.0.339240015183.issue13988@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Florent,
Your updated patch looks good. I think that the explicit import of _namespace_map into cElementTree is just to satisfy some weird magic in the tests and can probably be removed as well (along with the weird magic :-), but that's not really important and can be left for later cleanups.
Regarding the documentation, alright let's not mention the implementation detail, and your "versionchanged" addition makes sense. I don't think adding directly to whatsnew/3.3.rst is necessary, updating Misc/NEWS is enough.
I'll apply the documentation patch after you apply the code patch. Or if you want, you can apply it yourself, I don't mind.
Thanks for the cooperation! |
|