Message152885
| Author |
Mark.Shannon |
| Recipients |
Mark.Shannon, benjamin.peterson, giampaolo.rodola, gregory.p.smith, jcea, jcon, pitrou, pjenvey, rhettinger, terry.reedy, vstinner |
| Date |
2012年02月08日.16:34:12 |
| SpamBayes Score |
6.27977e-05 |
| Marked as misclassified |
No |
| Message-id |
<4F32A406.70604@hotpy.org> |
| In-reply-to |
<1328711858.73.0.565565457867.issue13903@psf.upfronthosting.co.za> |
| Content |
Antoine Pitrou wrote:
> Antoine Pitrou <pitrou@free.fr> added the comment:
>
> Looking at your latest patch, I worry about "any deletion
> +(including pop & popitem) causes a split table to become a combined table". Why wouldn't you use a dummy pointer (such as ((PyObject *) 1)) to signal deleted slots?
In fact here is no need for a dummy pointer.
When deleting from a split-table, the value can just be set to NULL,
the resulting key-NULL pair is legal in a split-table.
Your suggestion doesn't make the code any more complex, so I've included it.
In practice, it will very rare that a deletion occurs in a split table
(since they are only used for attribute dictionaries). |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2012年02月08日 16:34:13 | Mark.Shannon | set | recipients:
+ Mark.Shannon, rhettinger, terry.reedy, gregory.p.smith, jcea, pitrou, vstinner, giampaolo.rodola, pjenvey, benjamin.peterson, jcon |
| 2012年02月08日 16:34:12 | Mark.Shannon | link | issue13903 messages |
| 2012年02月08日 16:34:12 | Mark.Shannon | create |
|