Message 152541 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	mark.dickinson
Recipients	eric.smith, jcea, mark.dickinson, python-dev, samuel.iseli
Date	2012年02月03日.16:50:20
SpamBayes Score	2.6525002e-05
Marked as misclassified	No
Message-id	<1328287821.02.0.723629164688.issue13889@psf.upfronthosting.co.za>

Content
General shape of the patch looks good. I'd suggest using a mask of _MCW_PC \| _MCW_RC instead of just _MCW_PC, so that the rounding mode is also set correctly. Probably rarely an issue in practice, but it's the same thing that we're doing on Linux. If this is going near the maintenance branches (2.7, 3.2), we need to be very careful. Have you had the opportunity to test the patch (e.g., run the complete Python test suite) both on 32-bit and 64-bit Windows?

Content

General shape of the patch looks good.
I'd suggest using a mask of _MCW_PC | _MCW_RC instead of just _MCW_PC, so that the rounding mode is also set correctly. Probably rarely an issue in practice, but it's the same thing that we're doing on Linux.
If this is going near the maintenance branches (2.7, 3.2), we need to be very careful.
Have you had the opportunity to test the patch (e.g., run the complete Python test suite) both on 32-bit and 64-bit Windows?

History
Date	User	Action	Args
2012年02月03日 16:50:21	mark.dickinson	set	recipients: + mark.dickinson, jcea, eric.smith, python-dev, samuel.iseli
2012年02月03日 16:50:21	mark.dickinson	set	messageid: <1328287821.02.0.723629164688.issue13889@psf.upfronthosting.co.za>
2012年02月03日 16:50:20	mark.dickinson	link	issue13889 messages
2012年02月03日 16:50:20	mark.dickinson	create

homepage