Message151740
| Author |
pitrou |
| Recipients |
Arfrever, amaury.forgeotdarc, denilsonsa, eric.araujo, giampaolo.rodola, loewis, neologix, pitrou, rosslagerwall, vstinner, zbysz |
| Date |
2012年01月21日.19:04:35 |
| SpamBayes Score |
1.8266366e-08 |
| Marked as misclassified |
No |
| Message-id |
<1327172559.3382.15.camel@localhost.localdomain> |
| In-reply-to |
<1327154257.69.0.829737696328.issue13609@psf.upfronthosting.co.za> |
| Content |
> > Does this need need more discussion, code review, testing,
> > or just more time?
>
> As I already wrote, I would prefer a very simple
> os.get_terminal_size() function: don't read environment varaiables,
> use a simple tuple instead of a new type, and raise an error if the
> size cannot be read (so no need of default values). The os module is
> written as a thin wrapper between Python and the OS. A more high level
> function (read environment variables, handle the error, use a
> namedtuple) can be written in your application, or maybe in another
> module.
I think we have reached the point where we won't be in total agreement
over the API, so let's choose whatever is submitted as a patch.
I only have two remaining issues with the patch:
- the tests needn't be in a separate file, they can go in test_os
- there should be a test for get_terminal_size_raw as well (and of
course it should be skipped if the function doesn't exist) |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2012年01月21日 19:04:58 | pitrou | set | recipients:
+ pitrou, loewis, amaury.forgeotdarc, vstinner, giampaolo.rodola, eric.araujo, Arfrever, zbysz, denilsonsa, neologix, rosslagerwall |
| 2012年01月21日 19:04:36 | pitrou | link | issue13609 messages |
| 2012年01月21日 19:04:35 | pitrou | create |
|