Message 151403 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	jaraco
Recipients	alexreg, amaury.forgeotdarc, asvetlov, brian.curtin, eric.araujo, jaraco, ncoghlan, santoso.wijaya, wkornewald
Date	2012年01月16日.19:00:03
SpamBayes Score	1.9698507e-09
Marked as misclassified	No
Message-id	<1326740403.82.0.00266680723774.issue6727@psf.upfronthosting.co.za>

Content
I ported the patch to the 3.2 branch. This port required more extensive adjustments. In particular, the NullImporter no longer used (char *) for directory detection, but instead used platform-specific PyObjects. Therefore, the 3.2 diff creates a new function, Py_PathIsDir, which takes a PyUnicode on Windows and PyBytes on other platforms and calculates the directory state of the parameter. I'm fairly unhappy with the way the patch for 2.7 and 3.1 translated to 3.2. So, I'm seeking review and approval of the 2.7 and 3.1 patches, and comments on the 3.2 patch.

Content

I ported the patch to the 3.2 branch. This port required more extensive adjustments. In particular, the NullImporter no longer used (char *) for directory detection, but instead used platform-specific PyObjects.
Therefore, the 3.2 diff creates a new function, Py_PathIsDir, which takes a PyUnicode on Windows and PyBytes on other platforms and calculates the directory state of the parameter.
I'm fairly unhappy with the way the patch for 2.7 and 3.1 translated to 3.2.
So, I'm seeking review and approval of the 2.7 and 3.1 patches, and comments on the 3.2 patch.

History
Date	User	Action	Args
2012年01月16日 19:00:03	jaraco	set	recipients: + jaraco, amaury.forgeotdarc, ncoghlan, eric.araujo, brian.curtin, asvetlov, santoso.wijaya, wkornewald, alexreg
2012年01月16日 19:00:03	jaraco	set	messageid: <1326740403.82.0.00266680723774.issue6727@psf.upfronthosting.co.za>
2012年01月16日 19:00:03	jaraco	link	issue6727 messages
2012年01月16日 19:00:03	jaraco	create

homepage