Message 151141 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	Jim.Jewett
Recipients	Arfrever, Jean-Michel.Fauth, Jim.Jewett, belopolsky, benjamin.peterson, ezio.melotti, gvanrossum, mrabarnett, pitrou, python-dev, tchrist
Date	2012年01月12日.17:17:24
SpamBayes Score	1.4830685e-07
Marked as misclassified	No
Message-id	<1326388645.13.0.653867487918.issue12736@psf.upfronthosting.co.za>

Content
The currently applied patch ( http://hg.python.org/cpython/rev/f7e05d205a52 ) left some dead code in unicodeobject.c function fixup ( http://hg.python.org/cpython/file/f7e05d205a52/Objects/unicodeobject.c#l9386 ) has a shortcut for when the fixer doesn't make any actual changes. The removed fixers (like fixupper ) returned 0 rather than maxchar to indicate that. The only remaining fixer, fix_decimal_and_space_to_ascii (line 8839), does not. (I think fix_decimal_and_space_to_ascii should add a touched flag, but until it does, the shortcut dedup code is dead.) Also, around line 10502, there is an #if 0 section with code that relied on one of the removed fixers; is it time to remove that section?

Content

The currently applied patch ( http://hg.python.org/cpython/rev/f7e05d205a52 ) left some dead code in unicodeobject.c
function fixup ( http://hg.python.org/cpython/file/f7e05d205a52/Objects/unicodeobject.c#l9386 ) has a shortcut for when the fixer doesn't make any actual changes. The removed fixers (like fixupper ) returned 0 rather than maxchar to indicate that. The only remaining fixer, fix_decimal_and_space_to_ascii (line 8839), does not. (I think fix_decimal_and_space_to_ascii *should* add a touched flag, but until it does, the shortcut dedup code is dead.)
Also, around line 10502, there is an #if 0 section with code that relied on one of the removed fixers; is it time to remove that section?

History
Date	User	Action	Args
2012年01月12日 17:17:25	Jim.Jewett	set	recipients: + Jim.Jewett, gvanrossum, belopolsky, pitrou, benjamin.peterson, ezio.melotti, mrabarnett, Arfrever, Jean-Michel.Fauth, python-dev, tchrist
2012年01月12日 17:17:25	Jim.Jewett	set	messageid: <1326388645.13.0.653867487918.issue12736@psf.upfronthosting.co.za>
2012年01月12日 17:17:24	Jim.Jewett	link	issue12736 messages
2012年01月12日 17:17:24	Jim.Jewett	create

homepage