Message150899
| Author |
neologix |
| Recipients |
neologix, pitrou, python-dev, rosslagerwall |
| Date |
2012年01月08日.19:29:03 |
| SpamBayes Score |
8.061115e-09 |
| Marked as misclassified |
No |
| Message-id |
<CAH_1eM2y8AfhHjtA4N87itVYcx0GTrDdHpxTC-gqQiDi6Ga1Hw@mail.gmail.com> |
| In-reply-to |
<1326050087.71.0.970632965681.issue13739@psf.upfronthosting.co.za> |
| Content |
> For some reason, the second changeset broke the OpenIndiana buildbots:
>
I have absolutely no idea of why this doesn't work. I suspect
rewinddir() is a noop on OpenIndiana if readdir() hasn't been called.
I'll revert this commit.
> Also, wouldn't it be better to call rewinddir with the GIL released?
> (although I agree rewinddir shouldn't be expensive)
rewinddir() just changes a pointer, and calls - or ought to call -
lseek() on the FD. This should be fast, since no I/O is involved
(lseek() is not documented to return EINTR, for example). Releasing
the GIL has a cost :-) |
|