Message150487
| Author |
anacrolix |
| Recipients |
anacrolix, giampaolo.rodola, josiahcarlson, rosslagerwall, stutzbach |
| Date |
2012年01月03日.00:42:50 |
| SpamBayes Score |
3.950463e-07 |
| Marked as misclassified |
No |
| Message-id |
<1325551370.93.0.887366175636.issue13694@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
I don't believe it is. dispatcher.addr is only set if the connection is immediately established. It's set explicitly in dispatcher.__init__ if a socket is provided that is already connected. It's *not* set after a connection completes.
There are 2 solutions as I see it:
1) Set addr after a successful call to socket.connect indicates that a connection is being established. Currently this only occurs if the connection is not delayed.
2) Set the addr when a connect event completes. This would require making getpeername calls like in dispatcher.__init__ and would be significantly more expensive.
My patch implements method 1. This conforms to existing addr-setting behaviour in dispatcher.bind. |
|