Message149631
| Author |
pitrou |
| Recipients |
amaury.forgeotdarc, denilsonsa, giampaolo.rodola, pitrou, zbysz |
| Date |
2011年12月16日.17:32:03 |
| SpamBayes Score |
1.682103e-08 |
| Marked as misclassified |
No |
| Message-id |
<1324056723.82.0.244104141843.issue13609@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Ok, a couple of general comments:
- there is no point having a separate module for a single function; I think the os module (and posixmodule.c for the C side) is a reasonable place where to put this
- C code should be indented with 4 spaces increments and no tabs (see PEP 7)
- constants in C code should be uppercase
- C code should be C89-compliant and therefore we don't use named struct initializers (such as ".m_size = 0") |
|