Message 149293 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	sbt
Recipients	jcea, meador.inge, pitrou, sbt
Date	2011年12月12日.11:56:21
SpamBayes Score	4.681966e-11
Marked as misclassified	No
Message-id	<1323690983.09.0.164497179342.issue13577@psf.upfronthosting.co.za>

Content
> Ok, a couple of further (minor) issues: > - I don't think AssertionError is the right exception type. TypeError > should be used when a type mismatches (e.g. "not an unicode object"); > - you don't need to check for d_type being NULL, since other methods don't; > - if type_qualname == NULL, the original error should be retained. Fixed. (I suspect, though, that caching the value of __qualname__ is an unnecessary optimisation.)

Content

> Ok, a couple of further (minor) issues:
> - I don't think AssertionError is the right exception type. TypeError 
> should be used when a type mismatches (e.g. "not an unicode object");
> - you don't need to check for d_type being NULL, since other methods don't;
> - if type_qualname == NULL, the original error should be retained.
Fixed. (I suspect, though, that caching the value of __qualname__ is an unnecessary optimisation.)

History
Date	User	Action	Args
2011年12月12日 11:56:23	sbt	set	recipients: + sbt, jcea, pitrou, meador.inge
2011年12月12日 11:56:23	sbt	set	messageid: <1323690983.09.0.164497179342.issue13577@psf.upfronthosting.co.za>
2011年12月12日 11:56:22	sbt	link	issue13577 messages
2011年12月12日 11:56:22	sbt	create

homepage