Message 149286 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	pitrou
Recipients	jcea, meador.inge, pitrou, sbt
Date	2011年12月12日.11:05:57
SpamBayes Score	1.9012343e-06
Marked as misclassified	No
Message-id	<1323687958.63.0.231909332744.issue13577@psf.upfronthosting.co.za>

Content
Ok, a couple of further (minor) issues: - I don't think AssertionError is the right exception type. TypeError should be used when a type mismatches (e.g. "not an unicode object"); - you don't need to check for d_type being NULL, since other methods don't; - if type_qualname == NULL, the original error should be retained. Otherwise, looks good, thank you.

Content

Ok, a couple of further (minor) issues:
- I don't think AssertionError is the right exception type. TypeError should be used when a type mismatches (e.g. "not an unicode object");
- you don't need to check for d_type being NULL, since other methods don't;
- if type_qualname == NULL, the original error should be retained.
Otherwise, looks good, thank you.

History
Date	User	Action	Args
2011年12月12日 11:05:58	pitrou	set	recipients: + pitrou, jcea, meador.inge, sbt
2011年12月12日 11:05:58	pitrou	set	messageid: <1323687958.63.0.231909332744.issue13577@psf.upfronthosting.co.za>
2011年12月12日 11:05:58	pitrou	link	issue13577 messages
2011年12月12日 11:05:57	pitrou	create

homepage