Message 149235 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	pitrou
Recipients	jcea, meador.inge, pitrou, sbt
Date	2011年12月11日.18:32:22
SpamBayes Score	9.312148e-08
Marked as misclassified	No
Message-id	<1323628343.04.0.321770909559.issue13577@psf.upfronthosting.co.za>

Content
The patch should add some tests for the added functionality (I'm not sure where, but perhaps test_descr is a good location). Also, just a nitpick, you can use _PyObject_GetAttrId and the _Py_IDENTIFIER macro instead of interning the "__qualname__" string yourself. Note that extension (non-builtin) types will need to have their __qualname__ fixed before their methods' __qualname__ is usable: >>> collections.deque.__qualname__ 'deque'

Content

The patch should add some tests for the added functionality (I'm not sure where, but perhaps test_descr is a good location).
Also, just a nitpick, you can use _PyObject_GetAttrId and the _Py_IDENTIFIER macro instead of interning the "__qualname__" string yourself.
Note that extension (non-builtin) types will need to have their __qualname__ fixed before their methods' __qualname__ is usable:
>>> collections.deque.__qualname__
'deque'

History
Date	User	Action	Args
2011年12月11日 18:32:23	pitrou	set	recipients: + pitrou, jcea, meador.inge, sbt
2011年12月11日 18:32:23	pitrou	set	messageid: <1323628343.04.0.321770909559.issue13577@psf.upfronthosting.co.za>
2011年12月11日 18:32:22	pitrou	link	issue13577 messages
2011年12月11日 18:32:22	pitrou	create

homepage