Message147966
| Author |
petri.lehtinen |
| Recipients |
eric.smith, ezio.melotti, lekma, lemburg, mark.dickinson, petri.lehtinen, python-dev, ron_adam, vstinner, ysj.ray |
| Date |
2011年11月19日.19:30:36 |
| SpamBayes Score |
1.1207701e-13 |
| Marked as misclassified |
No |
| Message-id |
<1321731037.11.0.804993812878.issue7330@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Hi!
I'd like to have this committed to be able to fix #13349. So here's a review.
- In Doc/c-api/unicode.rst, the two "versionchanged:: 3.3" directives can be merged
- In tests, I'd use 'abcde' rather than 'xxxxx' to make sure that correct characters are copied to the output (hope you understand what I mean)
- No test checks that width and precision work on characters rather than bytes
- The changes to unicodeobject.c don't apply on top of current default branch. |
|