Message147491
| Author |
pitrou |
| Recipients |
alexis, eric.araujo, flox, francismb, higery, jlove, michael.mulich, nadeem.vawda, paul.moore, pitrou, python-dev, rpetrov, tarek, vinay.sajip, westley.martinez |
| Date |
2011年11月12日.14:42:46 |
| SpamBayes Score |
0.0011165919 |
| Marked as misclassified |
No |
| Message-id |
<1321108682.8829.4.camel@localhost.localdomain> |
| In-reply-to |
<1321108507.89.0.308466488672.issue13193@psf.upfronthosting.co.za> |
| Content |
> Antoine, I appreciate that you took time to fix this bug while I was
> without Internet and without Windows, but unfortunately I will have to
> backout your commit. Postel’s Law doesn’t win here: It is documented
> that the MANIFEST template only accepts /-delimited paths,
"Just like in the setup script, file and directory names in the manifest
template should always be slash-separated"
That's "should", not "must".
Also, I thought people did undocumented things with distutils, and we
had to support these undocumented uses?
> In the future, please feel free to add unittest.expectedFailure
> decorators to problematic tests when I’m too long to come up with a
> fix, so that other people can see when their commits add problems.
I don't see how adding "expected failures" solves anything. It's not
clear why this failure should have been expected, rather than a bug.
A "commit adding problem" should be fixed or reverted; marking some
failures expected is just dodging the issue. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2011年11月12日 14:42:47 | pitrou | set | recipients:
+ pitrou, paul.moore, vinay.sajip, nadeem.vawda, tarek, eric.araujo, rpetrov, flox, alexis, michael.mulich, westley.martinez, python-dev, jlove, higery, francismb |
| 2011年11月12日 14:42:46 | pitrou | link | issue13193 messages |
| 2011年11月12日 14:42:46 | pitrou | create |
|