Message146647
| Author |
pitrou |
| Recipients |
Arfrever, amaury.forgeotdarc, eric.araujo, nadeem.vawda, ned.deily, neologix, pitrou, rosslagerwall, terry.reedy, vstinner |
| Date |
2011年10月30日.17:30:39 |
| SpamBayes Score |
2.515622e-07 |
| Marked as misclassified |
No |
| Message-id |
<1319995840.62.0.0509665537284.issue12797@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Here is my quick review:
- shouldn't the opener also get the third open() argument (although it currently seems to always be 0o666)?
- when fdobj is NULL, you shouldn't override the original error
- PyLong_AsLong can fail (if the opener returns too large an int), you should check for that
Thank you! |
|