Message146482
| Author |
oberstet |
| Recipients |
eric.araujo, ezio.melotti, nailor, oberstet, orsenthil |
| Date |
2011年10月27日.08:36:20 |
| SpamBayes Score |
0.00083732826 |
| Marked as misclassified |
No |
| Message-id |
<1319704580.93.0.835632664964.issue13244@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
The patch as it stands will result in wrong behavior:
+ self.assertEqual(urllib.parse.urlparse("ws://example.com/stuff#ff"),
+ ('ws', 'example.com', '/stuff#ff', '', '', ''))
The path component returned is invalid for ws/wss and is invalid for any scheme following the generic URI RFC, since # must be always escaped in path components.
Is urlparse meant to follow the generic URI RFC?
IMHO, the patch at least should do the equivalent of
urlparse.uses_fragment.extend(wsschemes)
so users of urlparse can do the checking for fragment != "", required for ws/wss on their own. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2011年10月27日 08:36:21 | oberstet | set | recipients:
+ oberstet, orsenthil, ezio.melotti, eric.araujo, nailor |
| 2011年10月27日 08:36:20 | oberstet | set | messageid: <1319704580.93.0.835632664964.issue13244@psf.upfronthosting.co.za> |
| 2011年10月27日 08:36:20 | oberstet | link | issue13244 messages |
| 2011年10月27日 08:36:20 | oberstet | create |
|