Message145454
| Author |
pitrou |
| Recipients |
lemburg, loewis, pitrou, python-dev, vstinner |
| Date |
2011年10月13日.14:21:12 |
| SpamBayes Score |
0.00780526 |
| Marked as misclassified |
No |
| Message-id |
<1318515446.3209.3.camel@localhost.localdomain> |
| In-reply-to |
<1318508579.99.0.189416123823.issue13134@psf.upfronthosting.co.za> |
| Content |
> I think the >1 character sizes are overly complex in this patch, and
> still memchr isn't typically used for them. So I suggest to simplify
> the code and restrict it to 1-byte chars only.
I would rather propose to simplify the needle heuristic and only use it
when the lower byte is non-zero. A properly optimized memchr() (as in
the glibc / gcc) is definitely faster than our naïve loop. |
|