Message 144770 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	danken
Recipients	danken, ezio.melotti, jgarrison, m-samia, python-dev, r.david.murray, techtonik, thomaslee, tod
Date	2011年10月02日.12:03:17
SpamBayes Score	0.00045703124
Marked as misclassified	No
Message-id	<1317556999.25.0.183199780575.issue4147@psf.upfronthosting.co.za>

Content
Oh dear. Thanks, Enzio, for pointing out that former patch is wrong. It is also quite naive, since the whole NATURE of toprettyprint() is to add whitespace to Text nodes. Tomas Lee's http://bugs.python.org/file11832/minidom-toprettyxml-01.patch made an effort to touch only "simple" Text nodes, that are confined within a single <elem></elem>. I did not expect http://bugs.python.org/file23286/minidom-Text-toprettyxml.patch to get in so quickly, after the former one spent several years on queue. However now is time to fix it, possible by my second patch.

Content

Oh dear.
Thanks, Enzio, for pointing out that former patch is wrong. It is also quite naive, since the whole NATURE of toprettyprint() is to add whitespace to Text nodes. Tomas Lee's http://bugs.python.org/file11832/minidom-toprettyxml-01.patch made an effort to touch only "simple" Text nodes, that are confined within a single <elem></elem>.
I did not expect http://bugs.python.org/file23286/minidom-Text-toprettyxml.patch to get in so quickly, after the former one spent several years on queue. However now is time to fix it, possible by my second patch.

History
Date	User	Action	Args
2011年10月02日 12:03:19	danken	set	recipients: + danken, techtonik, thomaslee, ezio.melotti, r.david.murray, jgarrison, m-samia, tod, python-dev
2011年10月02日 12:03:19	danken	set	messageid: <1317556999.25.0.183199780575.issue4147@psf.upfronthosting.co.za>
2011年10月02日 12:03:18	danken	link	issue4147 messages
2011年10月02日 12:03:18	danken	create

homepage