Message144497
| Author |
mark.dickinson |
| Recipients |
alex, ezio.melotti, mark.dickinson, meador.inge, python-dev, terry.reedy |
| Date |
2011年09月24日.10:52:30 |
| SpamBayes Score |
1.9492725e-06 |
| Marked as misclassified |
No |
| Message-id |
<1316861551.62.0.563425870072.issue13012@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Ezio's patch looks fine to me, though as Meador points out in the Rietveld review, there are a couple of omissions that could be fixed.
Personally, I'm not so convinced of the value of upgrading all the existing uses of splitlines to use 'keepends'; I just wanted to be able to do this in *new* code. :-) I guess I'm +0 on the int -> bool changes (replacing .splitlines(1) with .splitlines(True)), and -0 on adding the extra 'splitlines' keywords throughout existing source. |
|