Message144400
| Author |
meador.inge |
| Recipients |
alex, belopolsky, jcea, meador.inge, ncoghlan, rfk, rhettinger |
| Date |
2011年09月22日.04:02:33 |
| SpamBayes Score |
2.28744e-05 |
| Marked as misclassified |
No |
| Message-id |
<1316664154.47.0.753662819154.issue11816@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
I took a quick look over the final patch (I will do a more thorough
review later). I like the general idea a lot. The first thing that
popped out at me are the names 'OpInfo' and 'get_opinfo'.
'OpInfo' makes it sound like information concerning only the opcode, but
these objects really represent bytecode instructions. I see a lot
of code in the future like:
for opinfo in dis.get_opinfo(thing):
process(opinfo)
which seems vague. The following seems clearer to me:
for instr in dis.bytecode_instructions(thing):
process(instr)
And instead of 'OpInfo' perhaps 'ByteCodeInstruction'. Even the current
'dis' documentation uses the terminology "Byte Code Instruction". |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2011年09月22日 04:02:34 | meador.inge | set | recipients:
+ meador.inge, rhettinger, jcea, ncoghlan, belopolsky, alex, rfk |
| 2011年09月22日 04:02:34 | meador.inge | set | messageid: <1316664154.47.0.753662819154.issue11816@psf.upfronthosting.co.za> |
| 2011年09月22日 04:02:33 | meador.inge | link | issue11816 messages |
| 2011年09月22日 04:02:33 | meador.inge | create |
|