Message 144053 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	neologix, vstinner
Date	2011年09月14日.21:52:28
SpamBayes Score	0.00024667452
Marked as misclassified	No
Message-id	<201109142352.12695.victor.stinner@haypocalc.com>
In-reply-to	<1316029884.26.0.0837911327487.issue12981@psf.upfronthosting.co.za>

Content
I don't think that it's a problem to remove private functions. Is it mandatory to send a non-empty message (first argument for sendmsg, b'x' in your patch)? The original C function sends a random byte :-) multiprocessing_recvfd() contains cmsg_level=SOL_SOCKET and cmsg_type=SCM_RIGHTS, your Python function doesn't check cmsg_level or cmsg_type. Should it be checked? I don't know sendmsg/recvmsg API. Do they guarantee to send/receive all data?

Content

I don't think that it's a problem to remove private functions.
Is it mandatory to send a non-empty message (first argument for sendmsg, b'x' 
in your patch)? The original C function sends a random byte :-)
multiprocessing_recvfd() contains cmsg_level=SOL_SOCKET and 
cmsg_type=SCM_RIGHTS, your Python function doesn't check cmsg_level or 
cmsg_type. Should it be checked?
I don't know sendmsg/recvmsg API. Do they guarantee to send/receive all data?

History
Date	User	Action	Args
2011年09月14日 21:52:29	vstinner	set	recipients: + vstinner, neologix
2011年09月14日 21:52:29	vstinner	link	issue12981 messages
2011年09月14日 21:52:28	vstinner	create

homepage