Message140155
| Author |
vinay.sajip |
| Recipients |
benjamin.peterson, eric.araujo, vinay.sajip |
| Date |
2011年07月11日.17:58:20 |
| SpamBayes Score |
2.1071978e-07 |
| Marked as misclassified |
No |
| Message-id |
<1310407101.06.0.821103833142.issue12536@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
See #12167 for background.
The BaseFix class creates a logger named with the filename when the set_filename method is called. This logger appears to never be used, but since set_filename could be called any number of times and loggers are effectively singletons and not garbage collected, this could lead to refleaks and unbounded memory usage for no benefit.
It's possible to output contextual information about a file being worked on without needing to create a logger with the filename.
I'm proposing that the references to the logger in BaseFix be removed, as the logger isn't used anyway, and the test suite runs without failures when the references are removed. This will allow progress on #12167. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2011年07月11日 17:58:21 | vinay.sajip | set | recipients:
+ vinay.sajip, benjamin.peterson, eric.araujo |
| 2011年07月11日 17:58:21 | vinay.sajip | set | messageid: <1310407101.06.0.821103833142.issue12536@psf.upfronthosting.co.za> |
| 2011年07月11日 17:58:20 | vinay.sajip | link | issue12536 messages |
| 2011年07月11日 17:58:20 | vinay.sajip | create |
|