Message 139848 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	vstinner
Recipients	vstinner
Date	2011年07月05日.11:02:44
SpamBayes Score	5.419649e-09
Marked as misclassified	No
Message-id	<1309863765.68.0.0768928595323.issue12494@psf.upfronthosting.co.za>

Content
subprocess_check_output-2.patch is a more complete patch: "fix" (?) call(), check_output() and getstatusoutput(). These functions kill the process if an exception occurs to not hang on wait() in Popen.__exit__(). Because of the kill, I don't know if the fix should be applied to 2.7 and 3.2. In case of an exception, is it better to keep the subprocess alive, or to kill it? If we keep it alive, the caller of the function cannot interact with the process, and we don't know exactly when it will finish. By "exception", I mean unexpected exceptions: check_output() handles explicitly the TimeoutExpired exception.

Content

subprocess_check_output-2.patch is a more complete patch: "fix" (?) call(), check_output() and getstatusoutput(). These functions kill the process if an exception occurs to not hang on wait() in Popen.__exit__().
Because of the kill, I don't know if the fix should be applied to 2.7 and 3.2. In case of an exception, is it better to keep the subprocess alive, or to kill it? If we keep it alive, the caller of the function cannot interact with the process, and we don't know exactly when it will finish.
By "exception", I mean unexpected exceptions: check_output() handles explicitly the TimeoutExpired exception.

History
Date	User	Action	Args
2011年07月05日 11:02:45	vstinner	set	recipients: + vstinner
2011年07月05日 11:02:45	vstinner	set	messageid: <1309863765.68.0.0768928595323.issue12494@psf.upfronthosting.co.za>
2011年07月05日 11:02:45	vstinner	link	issue12494 messages
2011年07月05日 11:02:45	vstinner	create

homepage