Message139757
| Author |
taleinat |
| Recipients |
MHordecki, efosmark, eric.araujo, flox, jonas.wagner, milesck, quentel, r.david.murray, taleinat, vstinner |
| Date |
2011年07月04日.12:11:23 |
| SpamBayes Score |
5.6683516e-09 |
| Marked as misclassified |
No |
| Message-id |
<1309781484.14.0.0685260052519.issue12411@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Yes, please submit the other additional tests in a separate issue.
The default value for boundary should surely be b"". A simple test should be added where cgi.parse_multipart() uses the default boundary.
If valid_boundary() is used only for cgi.parse_multipart() then it should be changed to validate that the boundary is a bytes instance (which would also make it simpler). Otherwise (if vaild_boundary() is also used elsewhere) cgi.parse_multipart() should itself check that the boundary is indeed a bytes instance, throwing a TypeError otherwise.
Tip: You should run the relevant tests, making sure they all pass, before submitting a patch. That way you really know that the patch actually works (as far as passing all of the tests).
Thanks for adding more stdlib tests :) |
|