Message139292
| Author |
vincele |
| Recipients |
benjamin.peterson, sandro.tosi, vincele |
| Date |
2011年06月27日.15:06:11 |
| SpamBayes Score |
6.091113e-07 |
| Marked as misclassified |
No |
| Message-id |
<1309187171.86.0.0602872471233.issue11302@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
I was testing exact matches on the strings because I think pypy wants to be as compliant as possible with cpython, and IMHO that include exception msgs as far as possible. I don't see any reason to be different just for the sake of it.
As a user I'd find strange not to get same exc msgs from different implementations, and it'll make me loose some time digging why those difference exist...
Back to the patch:
The multiline (and also differing offsets) are there for testing .lineno & .col_offset AST node's attributes. (there was a bug in pypy's implementation of those back then...)
Do you want that explained in the comment ?
Do you want me to add "self.assertIn("foobar", str(e))" in the tests, remove the comments or let them as in the patch #2 ? |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2011年06月27日 15:06:11 | vincele | set | recipients:
+ vincele, benjamin.peterson, sandro.tosi |
| 2011年06月27日 15:06:11 | vincele | set | messageid: <1309187171.86.0.0602872471233.issue11302@psf.upfronthosting.co.za> |
| 2011年06月27日 15:06:11 | vincele | link | issue11302 messages |
| 2011年06月27日 15:06:11 | vincele | create |
|