Message 139137 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	John.Edmonds
Recipients	John.Edmonds, alexis, eric.araujo, tarek
Date	2011年06月26日.01:41:20
SpamBayes Score	0.00029224475
Marked as misclassified	No
Message-id	<1309052482.64.0.305624875653.issue12169@psf.upfronthosting.co.za>

Content
Thanks for reviewing the patch. I don't believe I received an email for the review. I think I have addressed your comment about the usage of str(body) by removing the call to str() and changing the tests to use byte literals. As for the content-length changing in the tests, that is because encode_multipart uses '\r\n' to end lines while the previous code only ended lines in '\n'.

Content

Thanks for reviewing the patch. I don't believe I received an email for the review. I think I have addressed your comment about the usage of str(body) by removing the call to str() and changing the tests to use byte literals.
As for the content-length changing in the tests, that is because encode_multipart uses '\r\n' to end lines while the previous code only ended lines in '\n'.

History
Date	User	Action	Args
2011年06月26日 01:41:22	John.Edmonds	set	recipients: + John.Edmonds, tarek, eric.araujo, alexis
2011年06月26日 01:41:22	John.Edmonds	set	messageid: <1309052482.64.0.305624875653.issue12169@psf.upfronthosting.co.za>
2011年06月26日 01:41:22	John.Edmonds	link	issue12169 messages
2011年06月26日 01:41:22	John.Edmonds	create

homepage