Message139128
| Author |
vstinner |
| Recipients |
gkcn, jnoller, mouad, neologix, petri.lehtinen, terry.reedy, vstinner |
| Date |
2011年06月25日.23:02:01 |
| SpamBayes Score |
1.0421441e-11 |
| Marked as misclassified |
No |
| Message-id |
<1309042921.78.0.202359526463.issue12157@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
>Don't Try to use any fancy way to check if the join will hang,
> leave all the job to faulthandler.
> Victor, do you agree with the simpler method, depending
> on faulthandler to catch a hang in the test and fail it?
> Or is the explicit timeout better?
If the patch fixes the hang, there is no good reason to write code to handle a new hang.
We have generic "watchdogs":
- buildbot timeout (any Python version)
- regrtest timeout implemented using faulthandler (only in Python 3.x)
If you run directly the .py test file on a command line, you can still use CTRL+c or CTRL+z to interrupt / stop the process.
You may want to improve these generic watchdogs, but write a specific watchdog for one specific test function looks useless to me.
Remember that timeouts are not reliable: we have sometimes false failures because of very slow buildbots... For regrtest timeout, I tried 10, 15, 20 and 30 minutes before choosing a timeout of 60 minutes. For lower values, we have many false failures. |
|