Message138860
| Author |
vinay.sajip |
| Recipients |
alexis, eric.araujo, tarek, vinay.sajip |
| Date |
2011年06月23日.07:43:34 |
| SpamBayes Score |
1.2767565e-15 |
| Marked as misclassified |
No |
| Message-id |
<1308815016.03.0.685993126745.issue12391@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
There are a number of places in packaging.install where temporary directories are created, but never cleaned up:
1. In _move_files, if no destination path is passed in, one is created using mkdtemp(), but it's not clear where this would be deleted. Moreover, it's never called without a path and not part of the public API, so it would make sense to always expect a destination to be passed in (and update the docstring to match)
2. install_local_project, in the case of an archive, unpacks it into a mkdtemp()'d directory, but never deletes that directory later.
3. install_dists() also calls mkdtemp() if a path is not passed in, but it's not clear where this would be deleted. This should be changed to always require a path to be passed in. The install_from_infos accepts None as an install path and passes that to install_dists, but why are we being so generous? It's not asking a lot to be given an explicit path to install to.
Note: the DistInfo class in packaging.pypi.dist also does this kind of thing (in the download and unpack methods) - it would seem sensible to make similar changes there. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2011年06月23日 07:43:36 | vinay.sajip | set | recipients:
+ vinay.sajip, tarek, eric.araujo, alexis |
| 2011年06月23日 07:43:36 | vinay.sajip | set | messageid: <1308815016.03.0.685993126745.issue12391@psf.upfronthosting.co.za> |
| 2011年06月23日 07:43:35 | vinay.sajip | link | issue12391 messages |
| 2011年06月23日 07:43:34 | vinay.sajip | create |
|