Message138224
| Author |
neologix |
| Recipients |
baikie, loewis, neologix, pitrou, rosslagerwall, terry.reedy, vstinner |
| Date |
2011年06月12日.22:37:34 |
| SpamBayes Score |
0.0001391182 |
| Marked as misclassified |
No |
| Message-id |
<1307918255.48.0.510314783448.issue8372@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
The patches look good to me, except that instead of passing
(addrlen > buflen) ? buflen : addrlen
as addrlen argument every time makesockaddr is called, I'd prefer if this min was done inside makesockaddr itself, i.e. perform min(addrlen, sizeof(struct sockaddr_un)) in the AF_UNIX switch case (especially since addrlen is only used for AF_UNIX).
Also, this would be the occasion to put a short explanatory comment (possibility of non NULL-terminated sun_path and unreliable length returned by syscalls). |
|