Message137315
| Author |
neologix |
| Recipients |
jcon, nadeem.vawda, neologix, petri.lehtinen, pitrou, rich-noir |
| Date |
2011年05月30日.18:02:05 |
| SpamBayes Score |
2.9558447e-05 |
| Marked as misclassified |
No |
| Message-id |
<1306778525.99.0.947802293794.issue12021@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
The patch looks good to me.
In your test, you don't explicitely close the mmap object: it's not a problem with CPython since it will get unmmapped, and the file descriptor - if it's a file-backed mapping - will get closed, as soon as it gets out of scope, but it would be cleaner to close it explicitely with something like self.addCleanup(m.close). |
|