Message 136903 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	vstinner
Recipients	pitrou, python-dev, vstinner
Date	2011年05月25日.21:42:32
SpamBayes Score	0.01756867
Marked as misclassified	No
Message-id	<1306359752.92.0.00303667123268.issue12175@psf.upfronthosting.co.za>

Content
> You must Py_DECREF(all) first. > Also, you should check that "all" is either None or a bytes object. Right, fixed in bufferedreader_readall-2.patch. By the way, thanks for your reviews. So, do you think that fileio_readall.patch and bufferedreader_readall-2.patch should be commited, or these changes are useless?

Content

> You must Py_DECREF(all) first.
> Also, you should check that "all" is either None or a bytes object.
Right, fixed in bufferedreader_readall-2.patch. By the way, thanks for your reviews.
So, do you think that fileio_readall.patch and bufferedreader_readall-2.patch should be commited, or these changes are useless?

History
Date	User	Action	Args
2011年05月25日 21:42:33	vstinner	set	recipients: + vstinner, pitrou, python-dev
2011年05月25日 21:42:32	vstinner	set	messageid: <1306359752.92.0.00303667123268.issue12175@psf.upfronthosting.co.za>
2011年05月25日 21:42:32	vstinner	link	issue12175 messages
2011年05月25日 21:42:32	vstinner	create

homepage