Message136855
| Author |
pitrou |
| Recipients |
pitrou, vstinner |
| Date |
2011年05月25日.15:20:50 |
| SpamBayes Score |
0.002577786 |
| Marked as misclassified |
No |
| Message-id |
<1306336851.45.0.175710284572.issue12175@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
About rawiobase_readall.patch: why do you use PyObject_Size() if you know chunks is a list? PyList_GET_SIZE is much more efficient.
About bufferedreader_readall.patch:
+ PyBytes_Concat(&data, all);
+ if (data == NULL)
+ return NULL;
You must Py_DECREF(all) first.
Also, you should check that "all" is either None or a bytes object. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2011年05月25日 15:20:51 | pitrou | set | recipients:
+ pitrou, vstinner |
| 2011年05月25日 15:20:51 | pitrou | set | messageid: <1306336851.45.0.175710284572.issue12175@psf.upfronthosting.co.za> |
| 2011年05月25日 15:20:50 | pitrou | link | issue12175 messages |
| 2011年05月25日 15:20:50 | pitrou | create |
|