Message 136840 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	vstinner
Recipients	pitrou, vstinner
Date	2011年05月25日.12:13:58
SpamBayes Score	1.0702108e-08
Marked as misclassified	No
Message-id	<1306325640.48.0.610014463103.issue12175@psf.upfronthosting.co.za>

Content
FileIO.readall() reads the file position and size before each call to read(), to adjust the buffer size. Moreover FileIO.readall() calls lseek() on Windows: it should use _lseeki64() instead, to handle correctly file bigger than 2 GB (or maybe 4 GB? I don't know). Attached patch fixes both problems. -- BufferedReader.read() calls FileIO.read() until FileIO.read() returns an empty byte string. Why not calling FileIO.read() only once?

Content

FileIO.readall() reads the file position and size before each call to read(), to adjust the buffer size.
Moreover FileIO.readall() calls lseek() on Windows: it should use _lseeki64() instead, to handle correctly file bigger than 2 GB (or maybe 4 GB? I don't know).
Attached patch fixes both problems.
--
BufferedReader.read() calls FileIO.read() until FileIO.read() returns an empty byte string. Why not calling FileIO.read() only once?

History
Date	User	Action	Args
2011年05月25日 12:14:00	vstinner	set	recipients: + vstinner, pitrou
2011年05月25日 12:14:00	vstinner	set	messageid: <1306325640.48.0.610014463103.issue12175@psf.upfronthosting.co.za>
2011年05月25日 12:13:59	vstinner	link	issue12175 messages
2011年05月25日 12:13:59	vstinner	create

homepage