Message135310
| Author |
pitrou |
| Recipients |
benjamin.peterson, daniel.urban, jcon, pitrou, stutzbach |
| Date |
2011年05月06日.15:43:23 |
| SpamBayes Score |
0.0024203348 |
| Marked as misclassified |
No |
| Message-id |
<1304696604.76.0.121881969133.issue9971@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
+ if (n <= 0) {
+ if (written > 0 || n == 0)
+ break;
+ if (n == -2) {
+ Py_INCREF(Py_None);
+ res = Py_None;
+ }
+ goto end;
+ }
I think the logic is flawed: if n = -1 and written is > 0, the error will be silenced.
Other than that, the patch looks good to me. |
|