Message135308
| Author |
sdaoden |
| Recipients |
ixokai, nadeem.vawda, ned.deily, neologix, pitrou, python-dev, sdaoden, skrah, vstinner |
| Date |
2011年05月06日.15:33:05 |
| SpamBayes Score |
2.6879805e-05 |
| Marked as misclassified |
No |
| Message-id |
<20110506153255.GA66752@sherwood.local> |
| In-reply-to |
<1304643247.49.0.687409902496.issue11277@psf.upfronthosting.co.za> |
| Content |
On Fri, 6 May 2011 02:54:07 +0200, Nadeem Vawda wrote:
> I think so. [.]
> it turns out that the OS X sparsefile crash is also covered by
> LargeMmapTests.test_large_offset() in test_mmap [!!!]. [.]
So i followed your suggestion and did not do something on zlib no
more. Even if that means that there is no test which checksums an
entire superlarge mmap() region.
Instead i've changed/added test cases in test_mmap.py:
- Removed all context-manager usage from LargeMmapTests().
This feature has been introduced in 3.2 and is already tested
elsewhere. Like this the test is almost identical on 2.7 and 3.x.
- I've dropped _working_largefile(). This creates a useless large
file only to unlink it directly. Instead the necessary try:catch:
is done directly in the tests.
- (Directly testing after .flush() without reopening the file.)
- These new tests don't run on 32 bit.
May the juice be with you |
|