Message 134832 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	ezio.melotti
Recipients	brian.curtin, ezio.melotti
Date	2011年04月30日.02:38:43
SpamBayes Score	5.8210425e-10
Marked as misclassified	No
Message-id	<1304131125.38.0.0233543629153.issue11961@psf.upfronthosting.co.za>

Content
You can indent the "attribute" directives and avoid to repeat "STARTUPINFO." before every attribute. If STD_INPUT_HANDLE and the other constants are attributes of STARTUPINFO they should be indented too, otherwise a line that says that subprocess also provides those at module level might be better. Another short note at the beginning of the section that mentions that this class/attributes are available on Windows only would be good too. There's also some trailing whitespace that should be removed.

Content

You can indent the "attribute" directives and avoid to repeat "STARTUPINFO." before every attribute. If STD_INPUT_HANDLE and the other constants are attributes of STARTUPINFO they should be indented too, otherwise a line that says that subprocess also provides those at module level might be better.
Another short note at the beginning of the section that mentions that this class/attributes are available on Windows only would be good too.
There's also some trailing whitespace that should be removed.

History
Date	User	Action	Args
2011年04月30日 02:38:45	ezio.melotti	set	recipients: + ezio.melotti, brian.curtin
2011年04月30日 02:38:45	ezio.melotti	set	messageid: <1304131125.38.0.0233543629153.issue11961@psf.upfronthosting.co.za>
2011年04月30日 02:38:44	ezio.melotti	link	issue11961 messages
2011年04月30日 02:38:43	ezio.melotti	create

homepage