Message133906
| Author |
r.david.murray |
| Recipients |
amaury.forgeotdarc, georg.brandl, r.david.murray, sdaoden, twouters |
| Date |
2011年04月16日.20:17:29 |
| SpamBayes Score |
2.0511182e-08 |
| Marked as misclassified |
No |
| Message-id |
<1302985050.59.0.848109362051.issue11700@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Here's a patch that fixes the reported bug (calling close twice fails with an AttributeError) the simple way.
Note that there was actually a test for the buggy behavior, which is rather odd considering that there is also a 'closed' method that would fail similarly if close was ever called. (The only use for the existing 'closed' method that I can see is to see if somebody else closed the file out from under the ProxyFile, a 'feature' that seems of dubious utility.)
It seems clear to me that calling close more than once should be legal, so I fixed the test. closed will still report if the underlying file has been closed out from under ProxyFile.
Steffen, I still don't understand what you are trying to achieve with your patches. I plan to close this issue by applying my patch. |
|