Message133855
| Author |
gruszczy |
| Recipients |
alexis, brett.cannon, eric.araujo, gruszczy, tarek |
| Date |
2011年04月15日.17:25:17 |
| SpamBayes Score |
8.875092e-08 |
| Marked as misclassified |
No |
| Message-id |
<1302888318.63.0.447382325349.issue11841@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
The reason for the use of two constants is that previously there was comparison in the code with a hardcoded 'f':
if postdev[0] == 'f':
I think it's a common practice to create constants for such hardcoded values. Also this hit when I was making a patch. I didn't know, that 'f' was used in the code and when I changed _FINAL_MARKER to ('f',), some tests failed. Alternatively to what I did in the patch you can use:
if postdev[0] == _FINAL_MARKER[0]:
but it just doesn't feel right for me.
Anyway, I can't find packaging package in default branch of python. Where is the development done? I'd be happy to try to provide some more patches for this package, if there is a need for any. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2011年04月15日 17:25:18 | gruszczy | set | recipients:
+ gruszczy, brett.cannon, tarek, eric.araujo, alexis |
| 2011年04月15日 17:25:18 | gruszczy | set | messageid: <1302888318.63.0.447382325349.issue11841@psf.upfronthosting.co.za> |
| 2011年04月15日 17:25:17 | gruszczy | link | issue11841 messages |
| 2011年04月15日 17:25:17 | gruszczy | create |
|